Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Fix position from ImportFrom nodes - #153

Merged
juanjux merged 3 commits into
bblfsh:masterfrom
juanjux:fix/importfrom_pos
Apr 8, 2018
Merged

juanjux merged 3 commits into
bblfsh:masterfrom
juanjux:fix/importfrom_pos

Conversation

@juanjux

@juanjux juanjux commented Apr 6, 2018

Copy link
Copy Markdown
Contributor

Fixes #152.

Signed-off-by: Juanjo Alvarez [email protected]

Juanjo Alvarez added 2 commits April 6, 2018 16:22
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux added the bug label Apr 6, 2018
@juanjux juanjux self-assigned this Apr 6, 2018
@juanjux

juanjux commented Apr 6, 2018

Copy link
Copy Markdown
Contributor Author

CC @zurk

AstDict = Dict[Any, Any]
VisitResult = Union[Node, List[Node]]


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: pep8.
Good idea to add pep8 check into Travis.
I can help with that.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but not right now, I have tight deadlines. ;)

@juanjux
juanjux merged commit 6629fad into bblfsh:master Apr 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants