This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
Fix/misc annotations - #112
Merged
Merged
Conversation
abeaumont
reviewed
Sep 29, 2017
abeaumont
left a comment
abeaumont
left a comment
Contributor
There was a problem hiding this comment.
I think leaving either Function or Call along with Argument is useful, since it allows to differentiate between formal and actual parameters directly.
That's how the java driver is annotated at least, so in either case it should be made consistent among drivers.
Contributor
Author
|
Yes, thinking about it, and considering the dynamic nature of Python, something like: Could be much easier to parse if |
abeaumont
approved these changes
Sep 29, 2017
abeaumont
left a comment
abeaumont
left a comment
Contributor
There was a problem hiding this comment.
Hmmm, only Call or Function is used in java driver, but I like this more. The problem is that it's hard to filter function declarations in this new way. We need to think how to improve this, but it's out of the scope of this PR.
added 6 commits
October 2, 2017 18:44
- Remove Function and Declaration from arguments (they were wrong when in a call and superfluous when under a real declaration node). - Remove Call from arguments (the parent already have it). - Add the Module role to the root node. - Remove duplicated roles for comparisons inside comprehensions.
This was referenced Oct 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and superfluous when under a real declaration node).
Fixes #97 (and suggestions/findings from other issues).
Will be merged after the Python-driver refactor changes are.