Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Strange <nil> token. Should be None? #99

Closed

Description

@zurk

I found it in my visualization example:
https://gist.github.com/zurk/d314d67d9aac8843d3776c82cd738b40

8  ||             ┣ BINARY, THIS, EXPRESSION                                     
8  |var1|         ┃ ┣ LEFT, IDENTIFIER, EXPRESSION                               
7  ||             ┃ ┃ ┣ INCOMPLETE                                               
7  |\n|           ┃ ┃ ┗ ┗ DOCUMENTATION                                          
8  |<nil>|        ┃ ┗ BYTE, NUMBER, EXPRESSION, RIGHT 

If you take a look at the code, you will see that actually corresponds to None token.
Also, I doubt that None should have a NUMBER role, maybe NULL?

Activity

  1. zurk commented on Sep 27, 2017

    @zurk
    Author

    ok, If you just parse None via Babelfish, you will have this tree:

      ||      FILE                        
    1 ||      ┣ EXPRESSION                
    1 |<nil>| ┗ ┗ BYTE, NUMBER, EXPRESSION
    

    and I expected to get something like:

      ||      FILE                        
    1 ||      ┣ EXPRESSION                
    1 |None|  ┗ ┗ NULL, EXPRESSION
    

    May be something else, idk.

  2. zurk commented on Sep 27, 2017

    @zurk
    Author

    Also THIS role is strange in the example.

  3. juanjux commented on Sep 28, 2017

    @juanjux
    Contributor

    Was because of the desync between the SDK numeric roles, fixed in the latest version that should be incorporated in the python-driver 1.0.3 image.

    It's Literal, Null, Expression in the last version.

  4. zurk commented on Sep 28, 2017

    @zurk
    Author

    Yes, but the main question of issue is about <nil> token. It should be None I think.

  5. juanjux commented on Sep 28, 2017

    @juanjux
    Contributor

    Oh I skipped that one, sorry!

    I'll be fixed in PR #112 which includes misc annotation fixes (mostly from your reports). It'll probably be merged in version 1.0.4 of the driver, but this version could take some time since we're in the middle of a refactor of several components.

  6. self-assigned this
    on Sep 29, 2017
  7. juanjux commented on Sep 29, 2017

    @juanjux
    Contributor

    Fixed by #112 and #113 when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions