This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Duplication of IDENTIFIER role #96
Description
I found it in the output of this example https://gist.github.com/zurk/8f7dd974347925ae62c31d9441491613 for issue #94.
for self token we have role duplication:
<self>: ['IDENTIFIER', 'QUALIFIED', 'IDENTIFIER', 'EXPRESSION']
or for class1:
<class1>: ['IDENTIFIER', 'QUALIFIED', 'IDENTIFIER', 'EXPRESSION']
Activity
juanjux commentedon Sep 21, 2017
Yes, I think that with the current UAST it will be unavoidable to have some duplicated roles, trough I'm pretty sure most of the current ones can be eliminated. There is a feature request in the SDK to automatically eliminate duplicates (bblfsh/sdk#174) but I don't want to implement it yet precisely to detect these easily avoidable cases.
zurk commentedon Sep 22, 2017
Ok, got it!
It is not a big problem, so fix it when you are ready.
juanjux commentedon Oct 4, 2017
Fixed by #112, thanks for reporting.
juanjux commentedon Oct 4, 2017
Reopening, I checked that there are still some duplicated IDENTIFIER roles.
juanjux commentedon Oct 5, 2017
Fixed by #122.