column out of bounds #164

Activity

1. juanjux

   self-assigned this

   on Aug 9, 2018
2. juanjux

   added

   bug

   on Aug 9, 2018
3. juanjux commented on Aug 9, 2018

   

   juanjux

   on Aug 9, 2018

   Contributor

   More actions

   I'll take a look.
4. juanjux commented on Aug 9, 2018

   

   juanjux

   on Aug 9, 2018

   Last edited by juanjux

   Contributor

   More actions

   What version are you using? I can't reproduce this with python -m bblfsh -f file or adding it as an integration tests and running the generation command. I'm using the latest (v2.2.1) version of the driver and latest of bblfshd from Docker Hub.
5. smacker commented on Aug 9, 2018

   

   smacker

   on Aug 9, 2018

   Last edited by smacker

   ContributorAuthor

   More actions

   "python-driver version: v2.2.1 (build: 2018-08-02T18:39:59Z)"
   

   bblfshd latest.

   Sorry for misleading source! After wget it doesn't fail indeed! But it fails on my fixture. Diff:

   $ diff itsdangerous.py fixtures/large.py
   900c900
   <     default_serializer = _CompactJSON
   ---
   >     default_serializer = _CompactJSON
   \ No newline at end of file
   

   New driver:

   $ python -m bblfsh -f fixtures/large.py -e 127.0.0.1:9800 > /dev/null
   column out of bounds: 38 [1, 37]
   

   Old driver:

   $ python -m bblfsh -f fixtures/large.py -e 127.0.0.1:9432 > /dev/null
   (.pyenv) smacker at Maxims-MacBook-Pro in ~/Dev/bblfsh-benchmark on master*
   
6. juanjux commented on Aug 9, 2018

   

   juanjux

   on Aug 9, 2018

   Contributor

   More actions

   Yes, that was it, Vim was being a too good boy and was adding a newline at the end of the file, removing it (perl -pi -e 'chomp if eof' filename.py) now I can reproduce the problem.
7. juanjux

   closed this as completedin sdk#286on Aug 9, 2018
8. juanjux commented on Aug 9, 2018

   

   juanjux

   on Aug 9, 2018

   Last edited by juanjux

   Contributor

   More actions

   SDK updated. Drivers will need individual updates to get this fix, I'll update the python-driver now since it's the one you're finding the problem with and all the other drivers tomorrow.

   👍React with 👍1Reacted by Maxim Sukharev
9. juanjux

   reopened this on Aug 9, 2018
10. juanjux commented on Aug 9, 2018

    

    juanjux

    on Aug 9, 2018

    Contributor

    More actions

    v2.2.2 of the Python driver released which should incorporate the fix.
11. juanjux

    closed this as completedon Aug 9, 2018