Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Change position iterator unittest to match the expected ordering of the fixed libuast - #88

Merged
juanjux merged 1 commit into
bblfsh:masterfrom
juanjux:fix/sort_test
Mar 21, 2018
Merged

juanjux merged 1 commit into
bblfsh:masterfrom
juanjux:fix/sort_test

Conversation

@juanjux

@juanjux juanjux commented Mar 21, 2018

Copy link
Copy Markdown
Contributor

Requires: bblfsh/libuast/pull/79

Signed-off-by: Juanjo Alvarez [email protected]

@juanjux juanjux added the bug label Mar 21, 2018
@juanjux juanjux self-assigned this Mar 21, 2018
@juanjux
juanjux requested a review from dennwc March 21, 2018 10:35

@dennwc dennwc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that libuast release is missing

@juanjux

juanjux commented Mar 21, 2018

Copy link
Copy Markdown
Contributor Author

Should work now.

@juanjux
juanjux merged commit 0037d76 into bblfsh:master Mar 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants