Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

libuast: Bump to 1.4.1 and improve error handling - #56

Merged
juanjux merged 2 commits into
bblfsh:masterfrom
abeaumont:feature/improve-error-handling
Nov 3, 2017
Merged

libuast: Bump to 1.4.1 and improve error handling#56
juanjux merged 2 commits into
bblfsh:masterfrom
abeaumont:feature/improve-error-handling

Conversation

@abeaumont

@abeaumont abeaumont commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

Signed-off-by: Alfredo Beaumont [email protected]

@abeaumont
abeaumont requested a review from juanjux November 3, 2017 16:19
@juanjux

juanjux commented Nov 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

CI fails because of the ancient GCC in Travis. Add -std=gnu99 to the flags, which I don't know exactly how its done for Python packages, or declare the int outside the for loop.

@abeaumont

abeaumont commented Nov 3, 2017

Copy link
Copy Markdown
Contributor Author

I've explicitly removed c99 because it doesn't include strndup... I'll use gnu99 instead

@juanjux
juanjux merged commit 155de2c into bblfsh:master Nov 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@juanjux juanjux juanjux approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@abeaumont @juanjux