This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
Fix PB imports (#122) - #124
Merged
Merged
Conversation
Contributor
Author
|
@bzz This is the proper fix. No changes are required for the downstream projects. |
Changes: 1. Place pb files inside proto 2. Fix the generated grpc stubs. The grpc plugin is crazy and ignores ".in." in imports, it also does not respect the directory structure. 3. Prepend "bblfsh" to all the imports in the bindings 4. Remove the sys.path hacks 5. Add `isinstance` test So now we have absolute imports starting with "bblfsh" **everywhere** and no classes are duplicated. Signed-off-by: Vadim Markovtsev <[email protected]>
Signed-off-by: Vadim Markovtsev <[email protected]>
Contributor
Author
|
@dennwc Can you please merge and publish a new release on PyPi. |
dennwc
approved these changes
Sep 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
isinstancetestSo now we have absolute imports starting with "bblfsh" everywhere and no classes are duplicated.
Signed-off-by: Vadim Markovtsev [email protected]