Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Remove the Makefile, make setup.py retrieve the .pb files from release #36

Closed

Description

@juanjux

Doesn't make sense to have a Makefile when we have a setup.py file, also, we could remove the .pb files that were added to avoid a dependency on protoc from the pip package.

  • Move the functionality of the Makefile to the setup.py.
  • A --release switch should be added to setup.py to generate the .pb files.
  • The travis build should install protoc and call --release before the pip install.
  • The normal build called by pip install should check if the pb files are generated and if not, retrieve the right release zip from github an extract the files from there before install.

Activity

  1. self-assigned this
    on Sep 22, 2017
  2. changed the title [-]Remove the `Makefile`, move to `setup.py`, make `setup.py` retrieve the `.pb` files from release[/-] [+]Remove the `Makefile`, make `setup.py` retrieve the `.pb` files from release[/+] on Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions