This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
[feature request] easy import of DESCRIPTOR, Node #34
Description
Since it is hard to get DESCRIPTOR and Node modules, can we add it to bblfsh directly?
I suggest adding to __main__.py something like this:
import importlib
DESCRIPTOR = importlib.import_module(
"bblfsh.gopkg.in.bblfsh.sdk.%s.uast.generated_pb2" % bblfsh.sdkversion.VERSION).DESCRIPTOR
Node = importlib.import_module(
"bblfsh.gopkg.in.bblfsh.sdk.%s.uast.generated_pb2" % bblfsh.sdkversion.VERSION).NodeThen everyone can just do from bblfsh import Node, DESCRIPTOR.
Can make a PR if you approve.
Activity
zurk commentedon Sep 21, 2017
We have it as ast2vec part: https://github.com/src-d/ast2vec/blob/master/ast2vec/bblfsh_roles.py but I think it is more bblfsh related things.
juanjux commentedon Sep 21, 2017
Yes, that's ugly as Black Death, the init.py file should import all those.
zurk commentedon Sep 22, 2017
@juanjux btw, can we just somehow avoid
inin the directory path? It also solves this problem.juanjux commentedon Sep 22, 2017
I tried several alternatives, using symlinks, renaming the in to in_ in the protofiles... this one is the one that causes less pain and should not matter much if we import everything from __init__.py.
juanjux commentedon Nov 13, 2017
Implemented in 2.6.0.