This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
Unified comment handling - #73
Merged
Merged
Conversation
dennwc
reviewed
Mar 20, 2019
Contributor
Author
|
Initial feedback addressed in 972446d |
bzz
marked this pull request as ready for review
March 20, 2019 15:21
bzz
force-pushed
the
fix-all-comments-69
branch
2 times, most recently
from
March 20, 2019 20:41
dafaaa2 to
d594b07
Compare
Contributor
Author
|
After more considerations, decided to go back to our initial strategy - only knock off the comments from the node that are transformed to semantic UAST. |
Contributor
Author
dennwc
approved these changes
Mar 20, 2019
dennwc
left a comment
dennwc
left a comment
Member
There was a problem hiding this comment.
Looks good!
Only one question - it doesn't change any of the fixtures. I assume this was a bugfix, so it will be nice to add a fixture that actually shows the bug and fails without this patch, so we can check regressions.
Each drops off comments from the nodes that are already mapped to smeantic UAST and thus do not expect to have such properties Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
bzz
force-pushed
the
fix-all-comments-69
branch
from
March 20, 2019 21:28
d594b07 to
07e7b51
Compare
Contributor
Author
Totally forgot to include the fixture 🤦♂️ , thank you for catching! added in 07e7b51 |
dennwc
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69 by making sure all trailing/inner/leading comments are handled on all nodes