This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Missing token for StringLiteralTypeAnnotation #66
Description
how to reproduce:
wget https://raw.githubusercontent.com/reduxjs/redux/6949ba0ce1d25aca9fa40d250d81c7e09beff30f/examples/todos-flow/src/types/todos.js
docker run -d --rm --name style_analyzer_bblfshd_new --privileged -p 9432:9432 bblfsh/bblfshd\:v2.11.0 --log-level DEBUG
docker exec style_analyzer_bblfshd_new bblfshctl driver install javascript docker://bblfsh/javascript-driver:v2.6.0
docker cp todos.js style_analyzer_bblfshd_new:todos.js
docker exec -it style_analyzer_bblfshd_new bblfshctl parse todos.js | grep -A 16 StringLiteralTypeAnnotationoutput:
. . . . . . . . . . . . . . 1: StringLiteralTypeAnnotation {
. . . . . . . . . . . . . . . Roles: Declaration,Type,String,Literal
. . . . . . . . . . . . . . . StartPosition: {
. . . . . . . . . . . . . . . . Offset: 256
. . . . . . . . . . . . . . . . Line: 20
. . . . . . . . . . . . . . . . Col: 13
. . . . . . . . . . . . . . . }
. . . . . . . . . . . . . . . EndPosition: {
. . . . . . . . . . . . . . . . Offset: 266
. . . . . . . . . . . . . . . . Line: 20
. . . . . . . . . . . . . . . . Col: 23
. . . . . . . . . . . . . . . }
. . . . . . . . . . . . . . . Properties: {
. . . . . . . . . . . . . . . . internalRole: value
. . . . . . . . . . . . . . . . value: ADD_TODO
. . . . . . . . . . . . . . . }
. . . . . . . . . . . . . . }
--
. . . . . . . . . . . . . . 1: StringLiteralTypeAnnotation {
. . . . . . . . . . . . . . . Roles: Declaration,Type,String,Literal
. . . . . . . . . . . . . . . StartPosition: {
. . . . . . . . . . . . . . . . Offset: 303
. . . . . . . . . . . . . . . . Line: 21
. . . . . . . . . . . . . . . . Col: 13
. . . . . . . . . . . . . . . }
. . . . . . . . . . . . . . . EndPosition: {
. . . . . . . . . . . . . . . . Offset: 316
. . . . . . . . . . . . . . . . Line: 21
. . . . . . . . . . . . . . . . Col: 26
. . . . . . . . . . . . . . . }
. . . . . . . . . . . . . . . Properties: {
. . . . . . . . . . . . . . . . internalRole: value
. . . . . . . . . . . . . . . . value: TOGGLE_TODO
. . . . . . . . . . . . . . . }
. . . . . . . . . . . . . . }
It has value in its properties but no token.
Reacted by Alex
Activity
creachadair commentedon Mar 8, 2019
Is this a regression or a case where the token was never present (and still isn't)?
zurk commentedon Mar 8, 2019
It is a regression. It was present in v1.2.0
[-][bug] no token for StringLiteralTypeAnnotation for v2.6.0 driver[/-][+]Missing token for StringLiteralTypeAnnotation[/+]bzz commentedon Mar 11, 2019
Thank you for a very nice report @zurk !
It could be either this, or part of the #63 - will take a look as soon asap, but after initial scope of 2.7.0 milestone