Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Bump SDK version to 2.14.x - #108

Merged
bzz merged 2 commits into
bblfsh:masterfrom
bzz:sdk-update
Mar 1, 2019
Merged

bzz merged 2 commits into
bblfsh:masterfrom
bzz:sdk-update

Conversation

@bzz

@bzz bzz commented Mar 1, 2019 •

Copy link
Copy Markdown
Contributor

Moves driver to latest SDK for the next release.

  • update SDK
  • update fixtures

@bzz
bzz requested a review from dennwc March 1, 2019 15:12
@bzz
bzz marked this pull request as ready for review March 1, 2019 15:13
@bzz bzz self-assigned this Mar 1, 2019
Signed-off-by: Alexander Bezzubov <[email protected]>

@dennwc dennwc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but CI fails because of different UAST output.

This is probably due to the fixes in comment processing, so should not be an issue to update fixtures.

Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz

bzz commented Mar 1, 2019

Copy link
Copy Markdown
Contributor Author

@dennwc pushed the fixture update.
Does these changes in comment processing make sense?

@bzz
bzz requested a review from dennwc March 1, 2019 16:59

@dennwc dennwc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is exactly the thing I've mentioned in the latest demo - we now handle stylistic indentation better.

Feel free to merge once CI is green.

@bzz
bzz merged commit 1be0cb8 into bblfsh:master Mar 1, 2019
@bzz
bzz deleted the sdk-update branch March 1, 2019 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants