Update dist_info location generation to account for build tags#86
Closed
rydrman wants to merge 1 commit intobazel-contrib:masterfrom
Closed
Update dist_info location generation to account for build tags#86rydrman wants to merge 1 commit intobazel-contrib:masterfrom
rydrman wants to merge 1 commit intobazel-contrib:masterfrom
Conversation
|
Will close due lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pep-427 spec that is being followed when discovering dist_info data in python wheels allows for an optional build tag to exist.
Previously this was not taken into account and could make the dist_info appear missing when a build tag was used.
These changes update the way the dist_info path is generated to allow for the case where a build tag is included.