Allow consumers of pip_import to turn off quiet mode#305
Allow consumers of pip_import to turn off quiet mode#305prebeta wants to merge 0 commit intobazel-contrib:masterfrom
Conversation
There was a problem hiding this comment.
LGTM, thanks!
I don't think we (the maintainers) have discussed a sign off policy yet, so I'll follow this:
-
Simple changes:
One sign off required. The same maintainer can merge the PR after waiting two business days from the time of initial approval.
-
Complex change
Two maintainer sign off required
I'll merge this in a few days assuming nobody raises concern.
prebeta
force-pushed
the
bazel-master
branch
2 times, most recently
from
e0d35dc to
53e689b
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@prebeta are you able to rebase (fixing conflicts)? 🙏 |
Thanks for the ping. I just rebased 👍 |
prebeta
force-pushed
the
bazel-master
branch
2 times, most recently
from
305fd28 to
15122a7
Compare
4 participants
We've found that turning off the quiet flag is useful for debugging issues with pip_import. Maybe it could be beneficial to allow users to pass in quiet=False if they wanted to debug or just to have more logging.