Repository navigation
Первый коммит приложения - #1
Open
bastinda-ww wants to merge 1 commit into
Open
bastinda-ww wants to merge 1 commit into
bastinda-ww wants to merge 1 commit into
Conversation
|
|
||
| private String name; | ||
|
|
||
| private int distance; |
There was a problem hiding this comment.
Дистанция не относится к классу машины, скорее она относится к классу гонки, поэтому её лучше хранить там
Comment on lines
+17
to
+27
| public void setSpeed(int speed) { | ||
| this.speed = speed; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } |
There was a problem hiding this comment.
Сеттеры для скорости и имени не используются - их можно удалить
| public static void main(String[] args) { | ||
| System.out.println("Hello world!"); | ||
| Scanner in = new Scanner(System.in); | ||
| ArrayList<Car> listOfCar = new ArrayList<>(); |
There was a problem hiding this comment.
От хранения массива машин и лишнего цикла при определении победителя можно избавиться, если при вводе данных сразу вычислять победителя и хранить его в отдельной переменной, тогда программа будет требовать меньше памяти и работать быстрее
| if(in.hasNextInt()){ | ||
| speed = in.nextInt(); | ||
| in.nextLine(); | ||
| if(speed >= 0 && speed <= 250){ |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Первая проектная работа.