Re-work authentication to need only username/password - #323
Merged
Merged
Conversation
bachya
added
enhancement
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## dev #323 +/- ##
==========================================
+ Coverage 99.78% 99.90% +0.11%
==========================================
Files 13 13
Lines 943 1004 +61
==========================================
+ Hits 941 1003 +62
+ Misses 2 1 -1
Continue to review full report at Codecov.
|
bachya
changed the title
|
Code Climate has analyzed commit 94ac4e1 and detected 0 issues on this pull request. View more on Code Climate. |
Owner
Author
|
Coverage appears to be an issue with codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what the PR does:
Our friend @shamoon discovered that we can eliminate the previous, clunky authentication method with some magic under the hood – this allows users to simply log in with their credentials, perform the correct 2FA operation, and move forward.
Does this fix a specific issue?
Fixes #251
Checklist:
README.mdanddocs/with any new documentation.AUTHORS.md.