Use an asyncio lock for backoff-based refresh token attempts - #267
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 893 897 +4
=========================================
+ Hits 893 897 +4
Continue to review full report at Codecov.
|
|
Code Climate has analyzed commit 8965c15 and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what the PR does:
Even though #266 was a needed fix, there was still a possibility that multiple "backing-off" requests could attempt the refresh token flow at the same time (causing the same problem that #266 was trying to solve). This PR augments things with an
asynciolock to ensure that only one such task can attempt to refresh at a given time.Also, since I'm in here, this PR expands the access token expiration padding to give us a little more room.
Does this fix a specific issue?
N/A
Checklist:
README.mdanddocs/with any new documentation.AUTHORS.md.