Conversation
bachya
added
maintenance
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| LOCKED = 1 | ||
| UNLOCKED = 2 | ||
|
|
||
| def __init__( |
There was a problem hiding this comment.
Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Codecov Report
@@ Coverage Diff @@
## dev #255 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 707 713 +6
=========================================
+ Hits 707 713 +6
Continue to review full report at Codecov.
|
|
Code Climate has analyzed commit 1a09098 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
bachya
added a commit
to Abductist/simplisafe-python
that referenced
this pull request
Sep 27, 2021
* Re-architect library * Update docs
bachya
added a commit
that referenced
this pull request
Sep 27, 2021
* Update camera.py Added in the model type of the 1080p version of the SimpliCam * Update camera.py Removed the CAMERA_MODEL_CAMERA_1080 constant. Added the new outdoor camera's model type. * Update entity.py Added the new outdoor camera's entity id number * Update sphinx-rtd-theme requirement from ^0.5.0 to ^1.0.0 (#254) * Update sphinx-rtd-theme requirement from ^0.5.0 to ^1.0.0 Updates the requirements on [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) to permit the latest version. - [Release notes](https://github.com/readthedocs/sphinx_rtd_theme/releases) - [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst) - [Commits](readthedocs/sphinx_rtd_theme@0.5.0...1.0.0) --- updated-dependencies: - dependency-name: sphinx-rtd-theme dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Fix tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Bach <[email protected]> * Re-architect library (#255) * Re-architect library * Update docs * Update camera.py Added in the model type of the 1080p version of the SimpliCam * Update camera.py Removed the CAMERA_MODEL_CAMERA_1080 constant. Added the new outdoor camera's model type. * Update camera.py Added in the model type of the 1080p version of the SimpliCam * Update camera.py Removed the CAMERA_MODEL_CAMERA_1080 constant. Added the new outdoor camera's model type. * Update AUTHORS * Add device type * Fix tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Bach <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
Some method signatures have changed slightly; be sure to read the documentation.
Describe what the PR does:
This PR achieves a fairly substantial re-architecture of the library. The majority of it is under the hood, but some key points:
aresponsesfor the test frameworkDoes this fix a specific issue?
N/A
Checklist:
README.mdanddocs/with any new documentation.AUTHORS.md.