Add new camera models (and the concept of an "Outdoor Camera") - #250
Merged
Merged
Conversation
Added in the model type of the 1080p version of the SimpliCam
bachya
previously approved these changes
Aug 15, 2021
bachya
self-requested a review
August 15, 2021 04:42
bachya
requested changes
Aug 15, 2021
Removed the CAMERA_MODEL_CAMERA_1080 constant. Added the new outdoor camera's model type.
Abductist
commented
Sep 1, 2021
Abductist
left a comment
Abductist
left a comment
Author
There was a problem hiding this comment.
Added the new outdoor camera's model type to this request
Added the new outdoor camera's entity id number
bachya
changed the title
* Update sphinx-rtd-theme requirement from ^0.5.0 to ^1.0.0 Updates the requirements on [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) to permit the latest version. - [Release notes](https://github.com/readthedocs/sphinx_rtd_theme/releases) - [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst) - [Commits](readthedocs/sphinx_rtd_theme@0.5.0...1.0.0) --- updated-dependencies: - dependency-name: sphinx-rtd-theme dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Fix tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Bach <[email protected]>
* Re-architect library * Update docs
Added in the model type of the 1080p version of the SimpliCam
Removed the CAMERA_MODEL_CAMERA_1080 constant. Added the new outdoor camera's model type.
Added in the model type of the 1080p version of the SimpliCam
Removed the CAMERA_MODEL_CAMERA_1080 constant. Added the new outdoor camera's model type.
bachya
added
the
enhancement
|
Code Climate has analyzed commit 612430f and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## dev #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 713 715 +2
=========================================
+ Hits 713 715 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in the model type of the 1080p version of the SimpliCam
Describe what the PR does:
Does this fix a specific issue?
Fixes https://github.com/bachya/python-simplisafe/issues/
Checklist:
README.mdanddocs/with any new documentation.AUTHORS.md.