Skip to content

Make aiohttp ClientSession optional - #150

Merged
bachya merged 1 commit into
devfrom
session
Apr 21, 2020
Merged

bachya merged 1 commit into
devfrom
session

Conversation

@bachya

@bachya bachya commented Apr 21, 2020

Copy link
Copy Markdown
Owner

Describe what the PR does:

This PR makes the aiohttp ClientSession an optional parameter when creating an API object.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Apr 21, 2020
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit f8db85d and detected 0 issues on this pull request.

View more on Code Climate.

@codecov

codecov Bot commented Apr 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #150 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          538       544    +6     
=========================================
+ Hits           538       544    +6     
Impacted Files Coverage Δ
simplipy/api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2151d...f8db85d. Read the comment docs.

@bachya
bachya merged commit b352436 into dev Apr 21, 2020
@bachya
bachya deleted the session branch April 21, 2020 20:28
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Enhancement of the code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant