-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore(devtools): extract the DevTools extension into its own repository #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JosunLP
wants to merge
2
commits into
main
Choose a base branch
from
claude/ticket-205-implementation-eobw4b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make the external extension available before merging, or gate these references.
This PR removes the tracked
extension/directory and points the DevTools guide and related living documentation atbQuery/devtools-extension, but the supplied repository state is not yet public and does not contain the published implementation. Merging now would leave users directed to unavailable setup material. Publish the extension first, or update the availability and setup claims until the external repository is ready.📍 Affects 2 files
docs/guide/devtools.md#L107-L107(this comment)docs/introduction.md#L63-L63🤖 Prompt for AI Agents
Source: MCP tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Substantively right, and I am deliberately not changing the docs for it. Leaving this thread open, because it is a live merge blocker rather than something a commit here can close.
One detail corrected: the repository is not missing —
bQuery/devtools-extensionexists and its CI is running. What it does not yet have onmainis the implementation, because that lives in bQuery/devtools-extension#1, which is green and awaiting merge. So the consequence you describe is real: merge this today and the DevTools guide sends readers to a repository holding a template and workflows, not an extension.The resolution is ordering, not wording. It is stated in this PR's description ("Merge order matters"), and the maintainer has set the sequence explicitly:
Hedging the availability claims instead would mean writing text that is wrong the moment step 2 lands, then reverting it — churn that makes the history harder to read, for a window that is measured in minutes. The links are correct for the state this PR is meant to be merged into.
If step 2 were abandoned rather than merged, this PR should be closed rather than reworded, so the hedge would never be the right fix in either branch of that decision.
Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 1750
🏁 Script executed:
Length of output: 9778
@JosunLP, thanks for the clarification.Verification confirms that
bQuery/devtools-extension#1is open, clean, and unmerged. Its diff contains the bQuery DevTools implementation. Themainbranch still contains the BrowserExtensionTemplate implementation.The finding remains a merge-order blocker. No documentation change is necessary if this PR merges only after
bQuery/devtools-extension#1.🐇
✏️ Learnings added
You are interacting with an AI system.