fix(server): default file-route loader middleware to action middleware - #201
Merged
Conversation
Action/HTML routes got options.middlewares while the JSON loader endpoints
got a separate options.dataMiddlewares. A developer protecting mutations
with middlewares: [auth] but omitting dataMiddlewares exposed every
route's load() output as unauthenticated JSON at ${dataPath}<route> — an
authorization bypass by omission.
dataMiddlewares now defaults to middlewares when unset; pass an explicit
empty array to opt the loader routes out.
Fixes #181
Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #181 (Low; authz footgun by omission).
Action/HTML routes received
options.middlewares; the JSON loader endpoints received a separateoptions.dataMiddlewares. A developer who protects mutations withmiddlewares: [auth]but forgetsdataMiddlewaresexposed every route'sload()output as unauthenticated JSON at${dataPath}<route>— the loader mirrors the same data an authenticated page renders, so this is a plausible authorization bypass introduced by omission.Fix
dataMiddlewaresnow defaults tomiddlewareswhen unset (options.dataMiddlewares ?? options.middlewares). PassdataMiddlewares: []to explicitly opt loader routes out of the action chain. Documented on the option.Verification
middlewares: [auth]and nodataMiddlewares, the generated GET loader route inherits[auth]; with an explicitdataMiddlewares: []it opts out. The default-inheritance test fails on the pre-fix code.tsc --noEmitclean.🤖 Generated with Claude Code