fix(view): invoke bq-on handlers via evaluation, not a paren heuristic - #200
Merged
Conversation
bq-on decided 'bare reference vs. call' by testing whether the expression
string contained '('. This misfired on expressions with a non-top-level
paren, e.g. items.find(x=>x).handler: treated as a full expression,
evaluated once, and the returned handler was never invoked — the click
silently did nothing.
Both bq-on sinks now share runOnExpression: always evaluate via
evaluateRaw and, if the result is a function, invoke it with the event;
otherwise the evaluation itself was the side effect (count.value++,
handleClick($event)). The fragile string heuristic is gone.
Fixes #180
Co-Authored-By: Claude Fable 5 <[email protected]>
github-actions
Bot
added
view
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #180 (Low; correctness — silent no-op).
bq-ondecided "bare function reference vs. call" by testing whether the expression string contained(. This misfires on expressions where the paren is not the top-level call:was treated as a full expression, evaluated once, and the returned
handlerwas never invoked — the click silently did nothing.Fix
Both
bq-onsinks (on.tsandon-modifiers.ts) now sharerunOnExpression: always evaluate the expression viaevaluateRaw, and if the result is a function, invoke it with the event; otherwise the evaluation itself was the side effect (count.value++,handleClick($event)). The string heuristic is removed. (thisremains unbound for a function resolved from a member chain — use an explicit call when the receiver matters, as before.)Verification
items.find(matcher).handlernow fires; a bareonClickreference is invoked with the event. The inner-paren case is exactly what silently no-op'd on the pre-fix code.handleClick($event),count.value++/--/+=) still pass.tsc --noEmit+ eslint clean.🤖 Generated with Claude Code