fix(core): stop debounce double-invoking a single leading+trailing call - #198
Merged
Conversation
With { leading: true, trailing: true } a single call fired twice: the
leading branch invoked with preservePending=trailing (keeping pendingArgs),
then trailingTrigger saw pendingArgs still set and invoked again. The
leading invoke now clears pendingArgs; a subsequent call within the window
re-sets it (the leading branch is skipped), so the trailing edge still
fires only when the function was called more than once (lodash semantics).
Fixes #178
Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #178 (Low; correctness).
With
{ leading: true, trailing: true }, a single call double-invoked: the leading branch invoked withpreservePending = trailing(keepingpendingArgs), thentrailingTriggersawpendingArgsstill set and invoked again. One call → two invocations.Fix
The leading invoke now clears
pendingArgs. A subsequent call within the window re-setspendingArgs(the leading branch is skipped onceleadingDone), so the trailing edge still fires — but only when the function was called more than once, matching lodash semantics.Verification
fn(1); fn(2); fn(3)→[1, 3]) still passes.fn(1)now yields[1], not[1, 1]. It fails on the pre-fix code.tsc --noEmitclean.🤖 Generated with Claude Code