Skip to content

fix(ssr): insert titleTemplate title literally #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosunLP merged 1 commit into from
Jul 6, 2026
Merged

fix(ssr): insert titleTemplate title literally #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ssr/head.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@ export const createHeadManager = (): HeadManager => {
let html = '';
if (state.title !== null) {
const formatted = state.titleTemplate
? state.titleTemplate.replace(/%s/g, state.title)
? // Use a replacer function so the title is inserted literally — a bare
// replacement string would interpret `$&`/`$1`/`` $` ``/`$'` in the
// title as special replacement patterns and mangle the output.
state.titleTemplate.replace(/%s/g, () => state.title as string)
: state.title;
html += `<title>${escapeText(formatted)}</title>`;
}
Expand Down
9 changes: 9 additions & 0 deletions tests/ssr-runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,15 @@ describe('head manager', () => {
head.add({ title: 'Home', titleTemplate: '%s | Acme' });
expect(head.render()).toContain('<title>Home | Acme</title>');
});

it('inserts a title with special replacement patterns literally (#177)', () => {
const head = createHeadManager();
head.add({ title: 'Q&A $& more', titleTemplate: '%s | Acme' });
// `$&` in the title must not be interpreted as a replacement pattern.
// escapeText encodes the ampersands, so assert the literal `$&` survives.
expect(head.render()).toContain('$&amp; more');
expect(head.render()).toContain('| Acme');
});
});

describe('asset manager', () => {
Expand Down