fix(ssr): validate bq-style declarations in the pure renderer - #196
Merged
Conversation
The DOM-free setStyle concatenated bq-style property names and values into
the inline style attribute with no CSS-level validation. Attribute
escaping stops HTML breakout, but an untrusted value like
'x;} body{display:none' still injected extra declarations/rules
(UI-redress, exfiltration via background url()).
setStyle now drops declarations whose property is not a valid CSS
identifier or whose value contains injection characters (; { } <). The
DOM-backed renderer was already safe (it writes via CSSStyleDeclaration).
Fixes #176
Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
tests
Signed-off-by: Jonas Pfalzgraf <[email protected]>
The dev merge concatenated the #176 and #163 EOF test appends and dropped the closing braces of the #176 block, breaking type-check. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #176 (Low; CSS injection — no HTML breakout).
The DOM-free
setStyleconcatenatedbq-styleproperty names and values into the inlinestyleattribute with no CSS-level validation. Attribute escaping prevents HTML breakout, but an untrusted style value likex;} body{display:noneinjected extra declarations/rules (UI-redress/clickjacking, exfiltration viabackground: url(...)).Fix
setStyle(pure renderer) now drops any declaration whose property name is not a valid CSS identifier (--customor kebab-case) or whose value contains injection characters (;,{,},<). The DOM-backed renderer was already safe — it writes viaCSSStyleDeclaration.setProperty, which rejects malformed values.Verification
width: 'x;} body{display:none'is dropped; safe declarations (color,marginTop) pass through. The malicious case fails on the pre-fix pure renderer.tsc --noEmitclean.🤖 Generated with Claude Code