fix(store): guard deepClone against __proto__ key reassignment - #195
Merged
Conversation
deepClone assigned via bracket notation over Object.keys, so an own
enumerable __proto__ key (e.g. from JSON.parse('{"__proto__":{…}}'))
triggered the setter and reassigned the clone's prototype instead of
copying a data property, corrupting the object $patchDeep operates on.
deepClone now skips prototype-pollution keys via the shared
isPrototypePollutionKey helper.
Fixes #175
Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #175 (Low; robustness).
The store's
deepCloneassigned via bracket notation overObject.keys, so a state object with an own enumerable__proto__key (e.g. fromJSON.parse('{"__proto__":{…}}')) triggered the__proto__setter and reassigned the clone's prototype instead of copying a data property, corrupting the object$patchDeepoperates on. Contained (no globalObject.prototypepollution) but a fidelity bug.Fix
deepCloneskips prototype-pollution keys via the sharedisPrototypePollutionKeyhelper fromcore/utils/object.ts(already used bymerge).Verification
JSON.parse'd{"__proto__":{polluted:true},"safe":1}yields a clone whose prototype is stillObject.prototype, preservessafe, and does not pollute{}. Fails on the pre-fix code.tsc --noEmitclean.🤖 Generated with Claude Code