fix(i18n): use own-property checks for placeholder and key resolution - #194
Merged
Conversation
interpolate/ICU arg+select+plural used the 'in' operator (and resolveKey
traversed segments without a guard), so a placeholder or key colliding
with an Object.prototype member (toString, constructor, __proto__, …) was
treated as present and substituted with the inherited value instead of
being left as the literal {name} — a contract violation with a minor
native-function-source info leak.
All lookup sites now use Object.prototype.hasOwnProperty.call.
Fixes #174
Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #174 (Low; contract violation + minor info-shape leak).
interpolateand the ICUarg/select/pluralsites used theinoperator (andresolveKeywalked key segments without a guard), which resolves inheritedObject.prototypemembers. A placeholder or key matchingtoString/valueOf/constructor/__proto__/… was treated as present even whenparams/messagesdidn't own it, substituting the inherited value (e.g.Hello {toString}→ the native function source) instead of leaving the literal{name}intact.Fix
All lookup sites use
Object.prototype.hasOwnProperty.call(...):translate.ts:interpolateplaceholder check + defensive guard inresolveKeyicu.ts: sharedhasParam()helper used by thearg,select, andpluralcasesVerification
{toString}/{constructor}placeholders left intact; real params still substitute;resolveKeyreturnsundefinedfor inherited names; ICUarg/selectunaffected by inherited names. All three fail on the pre-fix code.tsc --noEmitclean.🤖 Generated with Claude Code