fix(reactive): abort superseded in-flight fetch on overlapping execute - #192
Merged
Conversation
useFetch stored one shared currentAbortController and overwrote it on every execute(). Overlapping executions (a watch refresh racing a manual refresh()/execute()) left the earlier fetch running and un-cancellable — its result was discarded by the executionId guard, but the request kept consuming network/CPU, and state.abort() could only cancel the latest. Rapid watch churn piled up in-flight requests. execute() now aborts the previous controller before starting a new attempt, so a superseded request is cancelled immediately. Fixes #172 Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
reactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #172 (Medium; correctness / resource exhaustion).
useFetchkept a single sharedcurrentAbortControllerand overwrote it on everyexecute(). When executions overlap (awatchrefresh racing a manualrefresh()/execute()), the earlier in-flight fetch was never aborted — its result was discarded by theexecutionIdguard, but the request kept consuming network/CPU, andstate.abort()could only cancel the most recent controller. Rapidwatchchurn piled up un-cancellable requests.Fix
execute()aborts the previous controller (currentAbortController?.abort()) before creating the new one. The superseded request is cancelled immediately. The existingfinallycleanup already only nulls the controller when it's still the current one, so no cross-execution clobbering.Verification
AbortSignalbecomesaborted, the second stays live. Fails without the fix.tsc --noEmitclean.🤖 Generated with Claude Code