fix(ssr): route DOM-backed evaluator through the CSP-safe parser - #187
Merged
Conversation
evaluateSSR fell back to new Function() for any non-trivial expression on
the DOM-backed renderer, re-introducing unsafe-eval on a path documented
as CSP-safe, and its dot-path fast-lane skipped isPrototypePollutionKey
so evaluateSSR('constructor.constructor', ctx) reached the Function
constructor.
evaluateSSR now delegates to evaluateExpression from expression.ts (the
same evaluator the pure renderer uses): no eval/Function fallback, and
member access is proto-guarded. Evaluator behaviour is now unified across
both SSR backends.
Fixes #167
Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167 (Medium; High where templates can carry untrusted content).
The DOM-backed
evaluateSSR(active whenever a global/configuredDOMParserexists) had two problems:new Function(...keys,return (${expr});)for any non-trivial expression —unsafe-evalon a path whose siblingexpression.tswas written specifically to avoid it.isPrototypePollutionKey, soconstructor.constructorwalked the prototype chain and returned theFunctionconstructor.Fix
evaluateSSRnow delegates to the shared, CSP-safeevaluateExpression(Pratt parser inexpression.ts) already used by the pure renderer. This removes thenew Functionfallback and the proto-lookup gap in one step, and unifies evaluator behaviour across both backends. The deadunwrap/isSignal/isComputedimports are dropped (unwrapping lives in the shared evaluator).Verification
constructor.constructoron the DOM backend yields noFunction(fails on the old code, passes now).a + b) still evaluates via the safe parser.new Functionremains insrc/ssr.tsc --noEmit+ eslint clean.🤖 Generated with Claude Code