Skip to content

fix(reactive): bound self-triggered effect re-runs instead of recursing - #186

Merged
JosunLP merged 2 commits into
devfrom
fix/166-effect-cycle-guard
Jul 6, 2026
Merged

fix(reactive): bound self-triggered effect re-runs instead of recursing#186
JosunLP merged 2 commits into
devfrom
fix/166-effect-cycle-guard

Conversation

@JosunLP

@JosunLP JosunLP commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #166 (High).

effect(() => { count.value = count.value + 1 }) re-entered its own observer synchronously (outside a batch, scheduleObserver invokes observers directly), recursing until RangeError: Maximum call stack size exceeded. Wrapping in batch() didn't help since the re-write happens during flush when batchDepth is 0.

Fix

The effect observer gets a re-entrancy guard (per-effect isRunning flag). A self-trigger while running sets reRunRequested and returns; the outer invocation drains re-runs in a bounded do/while loop (MAX_SYNC_RERUNS = 100, Vue-style):

  • Effects that settle (e.g. if (count.value < 5) count.value++) converge silently — final value 5, no warning.
  • True cycles stop after the bound and log cyclic effect update detected instead of crashing the tab.
  • Mutually-recursive effects are covered too: nesting depth stays bounded because the inner trigger only sets a flag.

Dispose-during-run semantics are preserved (cleanup still runs via the finally path).

Verification

  • Three new tests: unconditional self-write (no throw + warning), settling self-write (converges, no warning), self-write inside batch().
  • Full suite: 2989 pass / 0 fail. tsc --noEmit clean.

🤖 Generated with Claude Code

An effect that writes a signal it also reads re-entered its own observer
synchronously (scheduleObserver invokes observers directly outside a
batch), overflowing the stack. batch() did not help because the re-write
happens during flush when batchDepth is already 0.

The effect observer now carries a re-entrancy guard: a self-trigger while
running defers the re-run into a bounded loop (MAX_SYNC_RERUNS = 100).
Effects that legitimately settle (e.g. clamping writes) still converge
silently; true cycles stop after the bound with a 'cyclic effect update
detected' warning instead of crashing the page.

Fixes #166

Co-Authored-By: Claude Fable 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c44ab16d-9fa8-4663-b868-650166f50e7e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/166-effect-cycle-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added reactive Changes to the reactive module tests Chenges to the tests labels Jul 6, 2026
@JosunLP
JosunLP merged commit 4d2e4dd into dev Jul 6, 2026
9 checks passed
@JosunLP
JosunLP deleted the fix/166-effect-cycle-guard branch July 6, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reactive Changes to the reactive module tests Chenges to the tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant