fix(reactive): bound self-triggered effect re-runs instead of recursing - #186
Merged
Conversation
An effect that writes a signal it also reads re-entered its own observer synchronously (scheduleObserver invokes observers directly outside a batch), overflowing the stack. batch() did not help because the re-write happens during flush when batchDepth is already 0. The effect observer now carries a re-entrancy guard: a self-trigger while running defers the re-run into a bounded loop (MAX_SYNC_RERUNS = 100). Effects that legitimately settle (e.g. clamping writes) still converge silently; true cycles stop after the bound with a 'cyclic effect update detected' warning instead of crashing the page. Fixes #166 Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #166 (High).
effect(() => { count.value = count.value + 1 })re-entered its own observer synchronously (outside a batch,scheduleObserverinvokes observers directly), recursing untilRangeError: Maximum call stack size exceeded. Wrapping inbatch()didn't help since the re-write happens during flush whenbatchDepthis 0.Fix
The effect observer gets a re-entrancy guard (per-effect
isRunningflag). A self-trigger while running setsreRunRequestedand returns; the outer invocation drains re-runs in a bounded do/while loop (MAX_SYNC_RERUNS = 100, Vue-style):if (count.value < 5) count.value++) converge silently — final value 5, no warning.cyclic effect update detectedinstead of crashing the tab.Dispose-during-run semantics are preserved (cleanup still runs via the
finallypath).Verification
batch().tsc --noEmitclean.🤖 Generated with Claude Code