Skip to content

fix(store): snapshot subscribers before notifying #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosunLP merged 2 commits into from
Jul 6, 2026
Merged

fix(store): snapshot subscribers before notifying #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d7549
fix(store): snapshot subscribers before notifying
JosunLP Jul 6, 2026
10049f1
Merge branch 'dev' into fix/165-store-notify-snapshot
JosunLP Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/store/create-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,10 @@ export const createStore = <
}

const currentState = getCurrentState();
for (const callback of subscribers) {
// Iterate a snapshot: a callback may unsubscribe (splice) during
// notification, which would shift indices under a live iterator and
// silently skip the next subscriber. Mirrors the $onAction guard.
for (const callback of [...subscribers]) {
callback(currentState);
}

Expand Down
17 changes: 17 additions & 0 deletions tests/store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,23 @@ describe('Store', () => {
expect(states).toEqual([1]);
});

it('does not skip later subscribers when one unsubscribes during notify (#165)', () => {
const store = createStore({
id: 'counter-unsub-during-notify',
state: () => ({ n: 0 }),
});

const unsubA = store.$subscribe(() => unsubA());
const seen: string[] = [];
store.$subscribe(() => seen.push('B'));

store.n = 1;
expect(seen).toEqual(['B']);

store.n = 2;
expect(seen).toEqual(['B', 'B']);
});

it('should not create reactive dependencies when $state is accessed inside effect', () => {
const store = createStore({
id: 'counter',
Expand Down