fix(ssr): escape bq-text values on raw-text elements in pure renderer - #183
Merged
Conversation
setText wrote evaluated bq-text values verbatim as text children, and serializeTree emits text inside raw-text elements (script/style/textarea/ title) without escaping. An untrusted value like '</textarea><img src=x onerror=alert(1)>' could therefore close the element and inject live markup (stored XSS in the default backend on Node/Bun/Deno). setText now escapes when the target is a raw-text element, mirroring the existing bq-model reflection handling; the bq-model call site reuses it. Fixes #163 Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #163 (Critical).
In the default pure SSR renderer,
setTextwrotebq-textvalues verbatim as text children, andserializeTreeemits text inside raw-text elements (script/style/textarea/title) without escaping. An untrusted value like</textarea><img src=x onerror=alert(1)>closed the element and injected live markup — stored XSS in the default backend on Node/Bun/Deno.Fix
setTextnow escapes viaescapeTextwhen the target element is raw (el.raw), exactly mirroring the pre-existingbq-modelreflection handling (which already named this hazard). Thebq-modelcall site now reuses the centralized logic.Verification
<textarea bq-text>and<title bq-text>with the audit payloads, run against both backends (dom + pure), plus a no-double-escaping check for normal elements.tsc --noEmitclean.🤖 Generated with Claude Code