Skip to content

merge - #1

Open
azbyn wants to merge 71 commits into
azbyn:masterfrom
ncmpcpp:master
Open

azbyn wants to merge 71 commits into
azbyn:masterfrom
ncmpcpp:master

Conversation

@azbyn

@azbyn azbyn commented Jan 4, 2025

Copy link
Copy Markdown
Owner

No description provided.

arybczak and others added 30 commits January 3, 2021 17:53
Although this can already be set via mpd_host, having a separate option
is cleaner, and doesn't require setting the host when ncmpcpp already
detects it correctly.
* fix multiple values for vorbis comment

* add vorbis comment support for opus
* In #259 users request the ability to have ncmpcpp remain open when the
  terminal has a small size. Previously ncmpcpp would exit when there
  were less than 30 columns or 5 rows.
* After removing this constraint, ncmpcpp would freeze when terminal
  sizes went below those thresholds.
* Upon debugging, it became clear that ncmpcpp wasn't frozen, it was
  stuck in a very long for loop because it thought the display was
  unreasonably large (resulting from integer overflow).
* Preventing that overflow allows ncmpcpp to handle small sizes
  gracefully. No other changes to the rendering code were necessary.

Fixes #259
* add configurable column widths

* reorder to match config file

* fix possibly misleading documentation

* fix crash when integer out of bounds

* parse config string during initial processing

* use std::bind with length of list

* fix division by zero error

* use list_of

* change escaped_list_separator variable names
modern browsers don't support http
* Update settings.cpp

* Update settings.cpp
Fix unresponsive stall when server error occurs
Terminals that don't restore the terminal state when a program exits display stdin incorrectly after quitting. This is not a bug in readline.h as its examples use termios in the same way.
arybczak and others added 30 commits August 21, 2024 16:14
* Replace "hack" with hacky chars

* Remove unnecessary spaces

* Add config option visualizer_spectrum_use_legacy_chars
* use visualizer_spectrum_log_scale_{x,y} to control log scaling

* change sound ellipse character to the circle instead of the bar

* oops, should be determined by x-axis scaling

* rebase to upstream

* use values from Config directly

* fix that weird first-column screen-wrapping issue when drawing

* rebase to upstream

---------

Co-authored-by: whooie <[email protected]>
Co-authored-by: Andrzej Rybczak <[email protected]>
updated links
Their layout is problematic to match with regexes and changes often.
libc++ 22 passes it[n] instead of *(it + n) to the comparator in std::sort.
For a non-POD value type, boost::transform_iterator returns a proxy object
from operator[]. Template argument deduction fails on the proxy, so the
templated overloads of LocaleBasedSorting::operator() do not match.

This is a libc++ bug, reported upstream as
llvm/llvm-project#223290. Until it is fixed,
replace boost::transform_iterator in NC::Menu with TransformIterator, which
returns a real reference from operator[].

Fixes #663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.