Repository navigation
Add tire test reporting platform scaffold - #2
aykutmayali wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (to != null) { | ||
| query.append(" and testDate <= ?3"); | ||
| } | ||
| return find(query.toString(), labId, from, to).list(); |
There was a problem hiding this comment.
When /api/tests is called without all filters, findByFilters always passes three positional arguments to Panache even if the JPQL built in this method does not contain ?1/?2/?3. Panache will still bind those parameters, and JPA throws IllegalArgumentException: Parameter with that position [1] did not exist, making the list endpoint fail whenever any filter is omitted. Consider building the parameter list to match only the placeholders present in the query.
Useful? React with 👍 / 👎.
| - name: Install frontend deps | ||
| run: npm ci | ||
| working-directory: frontend |
There was a problem hiding this comment.
The CI workflow installs frontend dependencies using npm ci, but the repository does not include frontend/package-lock.json. npm ci exits with ERR! ci can only install with an existing package-lock.json or npm-shrinkwrap.json, so the frontend build job will fail on every run.
Useful? React with 👍 / 👎.
| @Injectable({ providedIn: 'root' }) | ||
| export class TestRunService { | ||
| private apiUrl = '/api/tests'; | ||
|
|
There was a problem hiding this comment.
All API calls are built against a hard-coded relative path (/api/tests), but in infra/docker-compose.yml the SPA is served by nginx on port 8081 with no proxy to the backend (backend listens on 8080 and exposes API_BASE_URL that is never used). As a result, browsers will request http://localhost:8081/api/... and receive 404s from nginx rather than the backend, leaving the UI unable to load data in the compose deployment.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
Codex Task