@claude review. Focus on critical issues: bugs, security vulnerabilities, logical errors, data loss risks, performance problems. Do NOT nitpick style, naming conventions, minor formatting, or subjective preferences — only flag issues that could break functionality or cause real harm in production.

Claude finished @axisrow's task in 2m 49s —— View job

Review: PR #464 — repoint removed-doc services at live WSDL

• Read changed files
• Analyze RESOURCE_MAPPING_V5 URL changes
• Analyze check_all_docs_urls.py WSDL validation
• Check downstream consumers of the docs field
• Post review

The core fix is correct: the 4 doc pages are genuinely 404, the WSDL endpoints are the only authoritative source still served, and they live inside the registry so the "no URL literals outside the registry" invariant is respected. The WSDL-validation branch in check_all_docs_urls.py (XML + wsdl:definitions/<definitions marker) is sound. No security or data-loss concerns.

Two issues, both low severity (neither blocks CI or the documented preflight), plus one note.

1. The PR's "never read at runtime / zero functional impact" claim is incorrect

docs is read at runtime. cli.py:314-321 looks up get_docs_url(command.name) for every command group and appends it to the --help epilog:

docs_url = get_docs_url(command.name or "")   # cli.py:316
if docs_url:
    docs_line = f"\b\nDocumentation: {docs_url}"

So direct dynamicads --help, direct vcards --help, direct smartadtargets --help, and direct dynamicfeedadtargets --help will now print:

Documentation: https://api.direct.yandex.com/v5/dynamictextadtargets?wsdl

This is not a functional break — the old doc URLs are dead 404s, so a live WSDL link is strictly better than a broken one — but the stated rationale is wrong, and there is a real user-facing help-text change. Worth correcting the PR description so reviewers/release notes reflect that --help now points these 4 groups at a WSDL file.

2. scripts/audit_wire_shape.py now derives malformed URLs for these services

audit_v5 builds per-method doc URLs via _v5_per_method_url(docs_base, op) (audit_wire_shape.py:588). With the new WSDL base, for dynamictextadtargets?wsdl + get it returns:

https://api.direct.yandex.com/v5/dynamictextadtargets?wsdl/get

— a garbage URL that will fetch-fail and emit docs_unreachable findings for all 4 services × every method. _v5_per_method_url's tail-chop heuristic assumes a …/ru/<svc> doc-page shape and doesn't recognize a ?wsdl query base.

This is not run in CI or the documented preflight (only the helper functions are unit-tested), so it doesn't fail the build — but anyone running the manual wire-shape audit will now get false "unreachable" noise for these 4 groups. Consider short-circuiting ?wsdl/.wsdl bases in audit_v5 (treat as a single __group__ target, skip per-method derivation). Fix this →

3. Note (not blocking): WSDL preflight depends on unauthenticated access

check_all_docs_urls.py now relies on api.direct.yandex.com/v5/<svc>?wsdl being publicly fetchable without a token. That holds today (author verified 200), but if Yandex ever gates the WSDL behind auth, preflight would report GONE/SMALL and hard-fail the release. No action needed now — just be aware the preflight surface moved from the docs host to the API host.

Verdict: The change fixes #463 correctly and is safe to merge. Recommend (a) correcting the "never read at runtime" claim in the PR body, and (b) optionally guarding the audit tool (#2) in this or a follow-up PR.
· branch fix/463-docs-url-drift

@claude review. Focus on critical issues: bugs, security vulnerabilities, logical errors, data loss risks, performance problems. Do NOT nitpick style, naming conventions, minor formatting, or subjective preferences — only flag issues that could break functionality or cause real harm in production.

Claude finished @axisrow's task in 1m 49s —— View job

Review: PR #464 — repoint removed-doc services at live WSDL

• Read changed files
• Analyze RESOURCE_MAPPING_V5 URL changes
• Analyze check_all_docs_urls.py WSDL validation
• Analyze audit_wire_shape.py __group__ change + test
• Post review

This revision resolves both findings from the prior review: the PR body now correctly states the --help epilog impact (no more "zero functional impact" claim), and audit_wire_shape.py now short-circuits WSDL bases instead of deriving the garbage …?wsdl/get URLs. The fixes are correct and safe to merge. No bugs, security issues, or data-loss risks.

I confirmed the only runtime consumer of docs is cli.py:316 (get_docs_url → --help epilog); test_cli.py:86 reads the value dynamically via get_docs_url(...), so it won't break. The parametrize inputs at test_audit_wire_shape.py:146-153 are function-level test cases for _v5_per_method_url, not registry assertions — also unaffected.

Verified specifics:

• audit_wire_shape.py:578 — docs_base = info.get("docs", "") defaults to "", so the .rstrip("/") on line 588 can't hit None. WSDL short-circuit logic is sound.
• check_all_docs_urls.py:107-109 runs the captcha check before the WSDL branch, so a rate-limit gate is still caught (returns None → retry) rather than misclassified as "WSDL markers absent".

One non-blocking observation (low severity)

check_all_docs_urls.py:114-117 validates WSDL purely by marker presence (wsdl:definitions / <definitions) with no minimum-size floor, whereas the repo's documented freshness guard (wsdl_coverage.fetch_wsdl, per CLAUDE.md "Docs/cache freshness guard") rejects WSDL bodies <3 KB. A truncated or partial response that still contains <definitions would pass here as OK. Real Yandex WSDLs are 14–21 KB, so this is unlikely to bite, but adding a small floor would keep the preflight consistent with the freshness-guard philosophy used elsewhere:

if url.rstrip("/").endswith("?wsdl") or url.endswith(".wsdl"):
    if ("wsdl:definitions" in lower or "<definitions" in lower) and len(body) >= 3072:
        return ("OK", f"GET {resp.status_code}, valid WSDL, {len(body)} bytes")
    return ("SMALL", f"WSDL markers/size insufficient ({len(body)} bytes)")

Apply this →

Verdict: ✅ Correctly fixes #463 and addresses the prior review. Safe to merge. The size-floor note is optional hardening, not a blocker.
· branch fix/463-docs-url-drift

@claude review. Focus on critical issues: bugs, security vulnerabilities, logical errors, data loss risks, performance problems. Do NOT nitpick style, naming conventions, minor formatting, or subjective preferences — only flag issues that could break functionality or cause real harm in production.

Claude finished @axisrow's task in 1m 19s —— View job

Review: PR #464 — repoint removed-doc services at live WSDL

• Read changed files (current state of branch)
• Re-check WSDL validation in check_all_docs_urls.py (incl. <3 KB floor)
• Re-check audit_wire_shape.py __group__ short-circuit + test
• Verify RESOURCE_MAPPING_V5 URL changes
• Post review

This is the third pass. Both prior findings (the misleading "zero functional impact" claim and the malformed …?wsdl/get audit URLs) are resolved, and the optional <3 KB WSDL floor from the last review has been added (MIN_WSDL_BYTES = 3_072, commit 72a3c0e). No bugs, security issues, logical errors, or data-loss risks. Safe to merge.

I re-verified the points that could plausibly still break:

check_all_docs_urls.py — order of checks in _probe is correct:

• Captcha markers (line 110-112) run before the WSDL branch, so a SmartCaptcha gate still returns None (retry) instead of being misread as "markers absent".
• HEAD-200 / non-redirect WSDL responses fall through to the GET (lines 82-86) and then into the WSDL branch — no premature OK same-path redirect short-circuit.
• The <3 KB floor (line 121) closes the truncated-body gap; markers-without-size now correctly reports SMALL. Consistent with wsdl_coverage.fetch_wsdl.

audit_wire_shape.py:578-604 — docs_base = info.get("docs", "") defaults to "", so "".rstrip("/").endswith("?wsdl") is safe (no None/crash); empty base falls into the else and is handled by the existing if not targets and docs_base guard. WSDL bases produce exactly one ("__group__", docs_base) target. The new test test_audit_v5_treats_wsdl_base_as_single_group_target asserts both the single-target shape and the absence of any ?wsdl/ URL — good regression coverage.

resource_mapping.py — the 4 URLs are repointed inside the registry, so the "no URL literals outside the registry" invariant (CLAUDE.md) holds. The only runtime consumer is get_docs_url → --help epilog (cli.py:316), which the PR body now correctly documents.

Non-blocking observations (no action required)

1. Preflight depends on unauthenticated WSDL access (already flagged by the author in the PR "Note"). api.direct.yandex.com/v5/<svc>?wsdl must be fetchable without a token; holds today. If Yandex ever gates WSDL behind auth, preflight would report GONE/SMALL and hard-fail a release. Awareness only.

2. ?wsdl detection is string-suffix based, not query-param parsing. …/vcards?wsdl matches; a hypothetical …/vcards?wsdl&v=5 would not. None of the registry entries use such a form, so this is purely theoretical — not worth adding parsing for.

Verdict: ✅ Correctly fixes #463 and incorporates all prior review feedback. No blocking issues. Recommend merge.

Note: I could not run the test suite locally (sandbox blocked pytest); this review is from code inspection. CI / the author's reported 2036 passed, 47 skipped covers execution.
· branch fix/463-docs-url-drift