[codex] Add adextensions CalloutFieldNames flag#359
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds strict CLI support for the Yandex Direct API AdExtensions.get nested projection CalloutFieldNames, exposed as the kebab-case flag --callout-field-names, and verifies the resulting request payloads via dry-run tests.
Changes:
- Added
direct adextensions get --callout-field-namesand wired it into the request body asCalloutFieldNames. - Ensured
--fieldscontinues to control only top-levelFieldNames, whileCalloutTextis requested only viaCalloutFieldNames. - Added dry-run and
--helpregression tests, plus validation rejecting explicitly empty--callout-field-names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| direct_cli/commands/adextensions.py | Adds the --callout-field-names option, parses it via shared CSV parsing, validates non-empty input when provided, and includes CalloutFieldNames in the request params. |
| tests/test_dry_run.py | Adds dry-run payload coverage + help visibility + empty-input rejection coverage for --callout-field-names. |
Owner
Author
|
@codex review. Focus on critical issues: bugs, security vulnerabilities, logical errors, data loss risks, performance problems. Do NOT nitpick style, naming conventions, minor formatting, or subjective preferences — only flag issues that could break functionality or cause real harm in production. |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced May 26, 2026
axisrow
added a commit
that referenced
this pull request
May 28, 2026
…nd keywordbids
Per Yandex Direct API WSDL (tests/wsdl_cache/sitelinks.xml,
tests/wsdl_cache/keywordbids.xml), the GetRequest of both services
declares nested *FieldNames request parameters that are independent
of the top-level FieldNames:
sitelinks.get -> SitelinkFieldNames (SitelinkFieldEnum)
keywordbids.get -> SearchFieldNames (KeywordBidSearchFieldEnum)
NetworkFieldNames (KeywordBidNetworkFieldEnum)
Previously the CLI either folded these into --fields (overloading the
top-level FieldNames projection) or auto-emitted defaults with no way
to override. Mirroring the reference pattern from PR #359
(--callout-field-names), this change exposes each *FieldNames
parameter as a dedicated kebab-case option.
- direct_cli/commands/sitelinks.py: add --sitelink-field-names. Empty
CSV input rejected with UsageError; omitted means the parameter is
not sent (server default).
- direct_cli/commands/keywordbids.py: add --fields,
--search-field-names, --network-field-names. Each falls back to the
COMMON_FIELDS default when not provided so existing behavior is
preserved.
- tests/test_dry_run.py: 11 new dry-run tests covering payload shape,
--help surface, and empty-CSV rejection for the new flags.
- tests/test_api_coverage.py: new regression test
test_every_nested_fieldnames_param_has_cli_option scans every cached
WSDL get request for *FieldNames parameters and verifies that each
one has a matching kebab-case CLI option, ensuring future separate
field-list parameters cannot silently disappear. Acknowledged
remaining gaps registered in NESTED_FIELDNAMES_EXCLUSIONS with a
pointer to follow-up issue #402.
Closes #360.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
axisrow
added a commit
that referenced
this pull request
May 28, 2026
…nd keywordbids (#403) Per Yandex Direct API WSDL (tests/wsdl_cache/sitelinks.xml, tests/wsdl_cache/keywordbids.xml), the GetRequest of both services declares nested *FieldNames request parameters that are independent of the top-level FieldNames: sitelinks.get -> SitelinkFieldNames (SitelinkFieldEnum) keywordbids.get -> SearchFieldNames (KeywordBidSearchFieldEnum) NetworkFieldNames (KeywordBidNetworkFieldEnum) Previously the CLI either folded these into --fields (overloading the top-level FieldNames projection) or auto-emitted defaults with no way to override. Mirroring the reference pattern from PR #359 (--callout-field-names), this change exposes each *FieldNames parameter as a dedicated kebab-case option. - direct_cli/commands/sitelinks.py: add --sitelink-field-names. Empty CSV input rejected with UsageError; omitted means the parameter is not sent (server default). - direct_cli/commands/keywordbids.py: add --fields, --search-field-names, --network-field-names. Each falls back to the COMMON_FIELDS default when not provided so existing behavior is preserved. - tests/test_dry_run.py: 11 new dry-run tests covering payload shape, --help surface, and empty-CSV rejection for the new flags. - tests/test_api_coverage.py: new regression test test_every_nested_fieldnames_param_has_cli_option scans every cached WSDL get request for *FieldNames parameters and verifies that each one has a matching kebab-case CLI option, ensuring future separate field-list parameters cannot silently disappear. Acknowledged remaining gaps registered in NESTED_FIELDNAMES_EXCLUSIONS with a pointer to follow-up issue #402. Closes #360. Co-authored-by: axisrow <[email protected]> Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds strict Yandex Direct API contract support for
AdExtensions.getCalloutFieldNames.Changes
direct adextensions get --callout-field-namesas the kebab-case CLI projection of APICalloutFieldNames.--fieldsscoped to top-levelFieldNames;CalloutTextis emitted only underCalloutFieldNames.--callout-field-namesinput.Validation
python3 -m black --check direct_cli/commands/adextensions.py tests/test_dry_run.pypython3 -m ruff check direct_cli/commands/adextensions.py tests/test_dry_run.pypython3 -m pytest tests/test_dry_run.py tests/test_cli.py -qpython3 -m pytest -qdirect adextensions get --types CALLOUT --fields Id,Type,State,Status --callout-field-names CalloutText --format json --dry-rungit diff --check