fix(event_handler): preserve commas in scalar query and header parameters - #8509
Open
leandrodamascena wants to merge 1 commit into
Open
leandrodamascena wants to merge 1 commit into
leandrodamascena wants to merge 1 commit into
Conversation
powertools-for-aws-oss-automation
Bot
added
the
size/L
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8509 +/- ##
===========================================
+ Coverage 96.88% 96.89% +0.01%
===========================================
Files 317 317
Lines 15899 15920 +21
Branches 1395 1400 +5
===========================================
+ Hits 15403 15425 +22
+ Misses 361 360 -1
Partials 135 135 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8508
Summary
Changes
Restores scalar query and header strings that event normalization split on commas before OpenAPI validation. Preserves sequence handling and distinguishes actual repeated parameters using each event's representation, including ALB URL decoding.
User experience
With validation enabled,
?search=hello,worldnow reaches astrhandler parameter intact instead of returning 422. Scalar fields in query models also retain the full value instead of silently receiving"hello". Headers such asX-Forwarded-Forpreserve the complete chain.Body normalization is unchanged.
Validation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.