Skip to content

recasting might happen on already cast objects (re-invokes) - #94

Merged
rjlohan merged 1 commit into
aws-cloudformation:masterfrom
jaymccon:recast_fix
Jun 17, 2020
Merged

rjlohan merged 1 commit into
aws-cloudformation:masterfrom
jaymccon:recast_fix

Conversation

@jaymccon

Copy link
Copy Markdown
Contributor

Issue #, if available: Fixes #90

Description of changes:

recast.py currently expects all primitives to be strings, which is the case for initial invocations, but re-invocations from cloudwatch events are passing in already recast events. This fix should handle that.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaymccon jaymccon mentioned this pull request Apr 29, 2020
@richardhboyd

Copy link
Copy Markdown
Contributor

I pulled this commit locally and it fixes the recasting problem I was seeing when I used int types in my schema.

@ammokhov
ammokhov self-requested a review June 1, 2020 17:10
@rjlohan
rjlohan merged commit 9a9229c into aws-cloudformation:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unsupported type error for supported type

4 participants