Repository navigation
Public CI runs - #68
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 13
Lines ? 680
Branches ? 56
=======================================
Hits ? 680
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
|
Going to add integration step after aws-cloudformation/cloudformation-cli#360 lands. What do you think of the codecov comments? Does it make sense, since we have 100% coverage? |
I'd suggest to remove it, will add an additional email per PR to watchers, and with no new info seeing as pre-commit tells us about coverage stats if it's < 100%. |
|
|
||
| This plugin library helps to provide runtime bindings for the execution of your providers by CloudFormation. | ||
|
|
||
| [](https://travis-ci.com/aws-cloudformation/cloudformation-cli-python-plugin) |
There was a problem hiding this comment.
should add a coverage badge too, 100% is quite impressive 😄
There was a problem hiding this comment.
i was going to add it, but if we're not doing codecov... maybe we should make our own 🥇
i'd be happy to consider it once we're happy with the state. i think we'll have to get a bit more sophisticated about tracking versions then though, e.g. somehow embedding the commit hash/tag into the package and then logging it when the CLI runs so we can correlate issues. |
4 participants
Issue #, if available: N/A
Description of changes: Use a CI runner that doesn't require logging in.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.