Skip to content

Catch ConnectionError when Docker isn't running - #66

Merged
tobywf merged 1 commit into
aws-cloudformation:masterfrom
tobywf:docker-not-running
Nov 29, 2019
Merged

Catch ConnectionError when Docker isn't running#66
tobywf merged 1 commit into
aws-cloudformation:masterfrom
tobywf:docker-not-running

Conversation

@tobywf

@tobywf tobywf commented Nov 28, 2019

Copy link
Copy Markdown
Contributor

Issue #, if available: #56

Description of changes: See issue. Error message is now:

$ cfn submit --dry-run
Starting Docker build. This may take several minutes if the image 'lambci/lambda:build-python3.7' needs to be pulled first.
=== Caught downstream error ===
Could not connect to docker - is it running?
---
If debugging indicates this is a possible error with this program,
please report the issue to the team and include the log file 'rpdk.log'.
Issue tracker: https://github.com/aws-cloudformation/aws-cloudformation-rpdk/issues

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tobywf tobywf added the enhancement New feature or request label Nov 28, 2019
@tobywf tobywf self-assigned this Nov 28, 2019
@tobywf
tobywf merged commit 97759b4 into aws-cloudformation:master Nov 29, 2019
@tobywf
tobywf deleted the docker-not-running branch November 29, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjlohan rjlohan Awaiting requested review from rjlohan
2 more reviewers
@jaymccon jaymccon jaymccon approved these changes
@johnttompkins johnttompkins johnttompkins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

See More

@tobywf tobywf

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobywf @jaymccon @johnttompkins