Repository navigation
Report progress - #64
Merged
Merged
Conversation
jaymccon
marked this pull request as ready for review
November 27, 2019 23:32
tobywf
reviewed
Nov 28, 2019
| if "callbackContext" in ser: | ||
| del ser["callbackContext"] | ||
| if self.errorCode: | ||
| ser["errorCode"] = self.errorCode.name |
Contributor
There was a problem hiding this comment.
fine for now, i think in future we'll want to have another class to be the cloudformation callback struct and have a method to convert from one to the other
Contributor
|
Also fixes #60 |
tobywf
approved these changes
Nov 28, 2019
| parsed = self._parse_request(event_data) | ||
| caller_sess, platform_sess, request, action, callback, event = parsed | ||
| # Acknowledge the task for first time invocation | ||
| if not event.requestContext: |
Contributor
There was a problem hiding this comment.
i think java also checks the invocation count if requestContext happens to be set: https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/d2cb70716ea42d87549b61d09a82d7abcb5c16e7/src/main/java/software/amazon/cloudformation/LambdaWrapper.java#L322
johnttompkins
approved these changes
Nov 29, 2019
tobywf
added a commit
that referenced
this pull request
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Also fixed #60
Description of changes:
completes support for async handlers. I've end-to-end tested async CREATE using both local and cloudwatch reinvocations.
I optimised for getting this pr in as quickly as possible, over making the code pristine. This gets the plugin fully functional and can iterate/improve from here as we go.
Also fixes a few small bug that were exposed during testing:
ProgressEventresponses (was gettingInternal Failureerrors)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.