Repository navigation
enable local and cloudwatch handler re-invocation while IN_PROGRESS - #63
Merged
Merged
Conversation
johnttompkins
left a comment
johnttompkins
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just had a couple questions about the tests
tobywf
reviewed
Nov 26, 2019
| assert mock_request.requestContext.get("invocation") == 1 | ||
|
|
||
|
|
||
| def test_schedule_reinvocation_cloudwatch_callback(): |
Contributor
There was a problem hiding this comment.
there are a lot of mocks here. i vastly prefer some decoupling, such as creating the platform session somewhere else
Contributor
Author
There was a problem hiding this comment.
reduced the mock count somewhat, session is created elsewhere, still quite a few mocks left though
tobywf
approved these changes
Nov 26, 2019
rjlohan
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #57
Description of changes:
doesn't include reportProgress which will come in a future pr.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.