Skip to content

implement CloudWatchScheduler class - #58

Merged
tobywf merged 6 commits into
aws-cloudformation:masterfrom
jaymccon:scheduler
Nov 25, 2019
Merged

tobywf merged 6 commits into
aws-cloudformation:masterfrom
jaymccon:scheduler

Conversation

@jaymccon

Copy link
Copy Markdown
Contributor

Issue #, if available: #57

Description of changes:

Implements scheduler class copying the behavior of the java implementation pretty closely.

Still need to be wired up, in the service of keeping the code review manageable, will leave that for a follow up pr.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaymccon
jaymccon requested a review from tobywf November 22, 2019 02:22
Comment thread src/cloudformation_cli_python_lib/scheduler.py Outdated
Comment thread src/cloudformation_cli_python_lib/scheduler.py Outdated
Comment thread src/cloudformation_cli_python_lib/scheduler.py Outdated
Comment thread src/cloudformation_cli_python_lib/utils.py Outdated
Comment thread src/cloudformation_cli_python_lib/utils.py Outdated
Comment thread tests/lib/scheduler_test.py
Comment thread tests/lib/scheduler_test.py Outdated
Comment thread tests/lib/scheduler_test.py
Comment thread tests/lib/scheduler_test.py

@tobywf tobywf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, appreciate you iterating on this! avoiding setattr or other mutating actions simplifies reasoning about what's going on and will hopefully make it more maintainable and debugable in future. fingers crossed

@tobywf
tobywf requested a review from johnttompkins November 24, 2019 19:23
Comment thread tests/lib/utils_test.py Outdated
Comment thread tests/lib/scheduler_test.py
Comment thread tests/lib/scheduler_test.py
@tobywf
tobywf merged commit d0d72fa into aws-cloudformation:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants