Repository navigation
refactor type hinting - #51
Merged
Merged
Conversation
Conflicts:
tests/lib/interface_test.py
python/rpdk/python/templates/models.py
…tead of renaming all types
Closed
A nice side-effect of using `_` is that the schema forbids properties from beginning with that character, so clashes shouldn't be possible.
tobywf
approved these changes
Nov 20, 2019
johnttompkins
approved these changes
Nov 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
resubmission of #44
Main aim of this pr is to simplify the representation of type hints in the handler and improve IDE resolution of types for inline hinting/validation.
A notable sacrifice was that I had to set the type for the
ResourceHandlerRequestinHandlerSignaturetoAnyto get mypy to accept that the actual handler was usingResourceHandlerRequestnotBaseResourceHandlerRequest.Previously PyCharm (didn't test other IDE's) was not able to resolve types for
ResourceModelorProgressEvent. Type completion/validation now works as expected.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.