Repository navigation
Identifier Utils Module - #126
Merged
Merged
Conversation
ammokhov
force-pushed
the
identifier-utils
branch
from
October 15, 2020 07:59
087daec to
5ca57fb
Compare
ammokhov
force-pushed
the
identifier-utils
branch
from
October 15, 2020 08:01
5ca57fb to
2f2f66b
Compare
Contributor
|
would be nice to get a usage example added to |
johnttompkins
suggested changes
Oct 15, 2020
johnttompkins
approved these changes
Oct 15, 2020
johnttompkins
left a comment
johnttompkins
left a comment
Contributor
There was a problem hiding this comment.
Everything else looks good other than the 13 issue
ammokhov
force-pushed
the
identifier-utils
branch
from
October 15, 2020 22:47
1d7e6cb to
ff0ebaa
Compare
ammokhov
force-pushed
the
identifier-utils
branch
from
October 15, 2020 23:07
ff0ebaa to
7fe68f8
Compare
omkhegde
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
added identifier utils module that generates cfn compliant resource name
stackName-logicalId-hashExample:
stack-name:
my-custom-stacklogical id:
myresourceoutput:
my-custom-stack-myresource-191b9b1a51f5By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.