Repository navigation
added new properties - #107
Merged
ammokhov merged 2 commits intoJul 16, 2020
Merged
Conversation
ammokhov
added
enhancement
|
It won't necessarily be 100% future proof, but you could probably just hard code the awsPartition as a helper func. if cn-north-1 || cn-northwest-1 == aws-cn |
rjlohan
approved these changes
Jul 15, 2020
jaymccon
approved these changes
Jul 15, 2020
Contributor
The other partitions are publicly documented as well, so we should hardcode those partitions as well while hardcoding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
additional properties to
BaseResourceHandlerRequestinterface:desiredResourceTags: Optional[Mapping[str, Any]]systemTags: Optional[Mapping[str, Any]]awsAccountId: Optional[str]region: Optional[str]awsPartition: Optional[str]**- there are no good methods in
boto.sessionorregionsto retrieve current partition. we can use get_available_partitions to get list of partitions but that is not what is needed. We cant get endpoint interface either as get_available_endpoints returns list ofstr. There is an outstanding PR to get partition by region boto/botocore#1715. We could replicate something like that but might make sense to just wait.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.