models.ResourceModel should be a child class of BaseResourceModel #55

Activity

1. tobywf commented on Nov 23, 2019

   

   tobywf

   on Nov 23, 2019

   Contributor

   More actions

   i thought it was?

   https://github.com/aws-cloudformation/aws-cloudformation-rpdk-python-plugin/blob/9eda207789e9d904a529dff802f5c73addacb2a7/python/rpdk/python/templates/models.py#L38

   mypy seems happy with this, is there any indication it doesn't work? we did have stronger guarantees around types via generics, but some IDEs struggled to auto-complete that (see #44 )

   👍React with 👍1Reacted by Ben Bridts
2. tobywf

   added

   questionFurther information is requestedFurther information is requested

   on Nov 23, 2019
3. benbridts commented on Nov 23, 2019

   

   benbridts

   on Nov 23, 2019

   ContributorAuthor

   More actions

   This may have been a race condition. In the sense that I generated the code before the type hint refactor was merged (and I didn't update my plugin since).

   I'll close this and reopen the issue if it doesn't work after I updated everything on my side
4. benbridts

   closed this as completedon Nov 23, 2019