Skip to content

Create typename variable when generating models.py #54

Closed
Closed
Create typename variable when generating models.py#54
Assignees
tobywf
Labels
enhancementNew feature or request

Description

@benbridts
benbridts
opened on Nov 21, 2019

If you want to throw an already exist error, you currently do:

raise exceptions.AlreadyExists('MyOrg::Foo::Bar', model.BarId)

It would be nice if this could be:

from models import resource_type
raise exceptions.AlreadyExists(resource_type, model.BarId)

or even

raise exceptions.AlreadyExists(model)

Activity

  1. tobywf
    self-assigned this
    on Nov 23, 2019
  2. tobywf
    added
    enhancementNew feature or request
    on Nov 23, 2019

  3. tobywf commented on Nov 23, 2019

    @tobywf
    tobywf
    on Nov 23, 2019
    Contributor

    that makes sense, we'll need the type name for metrics publishing anyway so this would be a great enhancement.

    just need to find a home for it. since it's very difficult to change the type name after initialisation of the codebase, i'd be inclined to add it to handlers.py as a constant and pass it to Resource when we initialise that.

  4. ammokhov
    closed this as completedon Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions